luci-proto-vpnc: expose defaultroute option in proto_vpnc.lua

Sometimes people only want the VPN connection to be a route to a specific
network, not the default gateway for all traffic.

I've tested this on my router and works fine!

Submitted-by: Whitronic <redacted>
[reword commit message]
Signed-off-by: Jo-Philipp Wich <redacted>

Merge pull request #2286 from kevinoid/fix_statistics_filename_quoting

luci-app-statistics: quote : in filenames for DEF

luci-app-statistics: quote : in filenames for DEF

: is used to delimit fields in DEF: rrd instructions, so when it appears
in a filename it must be escaped using \.[1]  This commit adds the
escaping.

I discovered the issue after configuring collectd-mod-ping to monitor an
IPv6 host (2001:19f0:5:727:5b56:205d:ff55:2208).  Accessing
https://192.168.0.1/cgi-bin/luci/admin/statistics/graph/ping would cause
the following messages to be logged:

    Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_avg_raw=/tmp/rrd/openwrthost/ping/ping-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
    Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_droprate_avg_raw=/tmp/rrd/openwrthost/ping/ping_droprate-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2

and the graphs would not display.  After applying this commit, the
graphs display correctly and no messages are logged.

1.  https://oss.oetiker.ch/rrdtool/doc/rrdgraph_data.en.html#IDEF

Signed-off-by: Kevin Locke <redacted>

luci-base: fix some long standing german mistranslations

Signed-off-by: Jo-Philipp Wich <redacted>

luci-mod-network: require unique MACs for DHCP leases

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: datatypes: add "unique" dummy validator

Add a dummy validator for the server side so that we can start using unique
in client side JS code.

Signed-off-by: Jo-Philipp Wich <redacted>

Merge pull request #2259 from pmelange/luci-app-olsr-new-json-lib

update luci-app-olsr to the new jsoninfo library

Merge pull request #2282 from TDT-AG/pr/20181114-luci-base

luci-base: allow optional default value for file browser

luci-lib-ipkg: move out of luci-base

Move the old luci.model.ipkg utility class into a separate package and
let the components using it depend on the new library package.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-mod-system: replace builtin opkg support with luci-app-opkg

Signed-off-by: Jo-Philipp Wich <redacted>

luci-mod-system: use luci.sys.process.exec() in system controller

Switch the system controller to the common luci.sys.process.exec() function
and drop the local ltn12_popen() and fork_exec() helpers.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-mod-system: prevent comment injection in mtdbackup endpoint

Rework the parameter handling to both prevent a crash when no parameter is
given and to prevent root command injection through the mtd index part of
the parameter value.

Fixes: 9840d310e ("modules: add backup module for mtdblock devices")
Signed-off-by: Jo-Philipp Wich <redacted>

applications: add luci-app-opkg

Add a new luci-app-opkg which is a feature-complete replacement for the
builtin opkg functionality of luci-mod-system using mostly client side
JavaScript to reduce the amount of server side processing.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-app-firewall: remove references to cbi_bind()

Use the standard addEventListener() instead. Also remove an old
cbi_validate_field() call referencing a not existing field.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-mod-status: use progressbar widgets on main status page

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: simplify apply widget code

 - Drop embedded CSS in favor to new global rules
 - Drop extraneous include of cbi.js
 - Use showModal() facilities
 - Fix a cosmetic bug in countdown timeout handling

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: add modal dialog functions

Add two new functions showModal() and hideModal() which will fade in and
close an open modal respectively.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-bootstrap: add modal/progressbar rules, cleanup

 - Add rules for modal dialogs and progress bar widgets
 - Drop redundant, unused or obsolete rules
 - Add spin utility class

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-openwrt: modal/progressbar rules, mobile improvements

 - Add rules for modal dialogs and progress bar widgets
 - Increase button and input size on mobile devices
 - Convert pt to px units
 - Add label and h5 styles
 - Add common flash and spin utility classes

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: add luci.sys.process.exec()

The new process.exec() function simplifies spawning external processes
and capturing their stdio.

Signed-off-by: Jo-Philipp Wich <redacted>

applications: drop luci-app-asterisk

This application was never useful to begin with, drop it to avoid
further confusion.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base, themes: dropdown behaviour improvements

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: remove dead code in cbi_validate_field()

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: enable validation for dropdown fields

Directly attach validation handlers to cbi dropdowns as well, this allows
validating dropdown choices made by the user, similar to how plain select
boxes are handled by the cbi JavaScript.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-openwrt: dropdown style tweaks

- Remove 2em min height, this looks out of place with the OpenWrt theme
- Only colorize invalid dropdown when not open
- Drop use of image background for invalid fields while we're at it

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-bootstrap: add invalid style for dropdowns

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-{freifunk-generic,material,openwrt}: z-index fixes

Ensure that open dropdowns cover active tooltips.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-bootstrap: z-index fixes

Lower z-index of header bar to allow tooltips and dropdowns to overlap it,
also increase the z-index of open dropdowns to ensure that they cover
active tooltip bubbles.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: set .value property of cbi dropdown elements

In order to make cbi dropdowns usable for validation and other code
expecting native form elements, set the .value DOM property on the
dropdown parent element whenever the selection is changed.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: properly handle cbi tooltips on nested elements

Rework the tooltip event delegation logic to prevent hiding the tooltop
when the cursor is moved to a children of the tooltip container element.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: avoid using .form property directly

In order to prepare support for calling cbi validation on non-native form
widgets, remove direct usages of the node.form property and lookup the
containing form using findParent() instead.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: fix passing multiple dropdown values in change event

Due to a misspelled property name, only the first value was passed in
the event details.

Fixes: c2b570998 ("luci-base: cbi.js: rework dropdown implementation")
Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: rework dynamic list template

Commit 7c7821833 ("luci-base, themes: rework dynlist and dropdown widgets")
changed the way we initialize dynamic lists on client side, avoiding the
need for pre-rendering the items on the server side.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: add ARIA label to reveal/hide password button

Fixes #2070.
Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: update german translation

Signed-off-by: Jo-Philipp Wich <redacted>

Merge pull request #2281 from TDT-AG/pr/20181114-luci-app-mwan3

luci-app-mwan3: add/remove options

Merge pull request #2277 from sotux/master

i18n: luci-base: update Simplified Chinese translation

Merge pull request #2284 from dibdot/travelmate

luci-app-travelmate: consolidate css

Merge pull request #2283 from dibdot/adblock

luci-app-adblock: consolidate css

Merge pull request #2280 from dibdot/banip

luci-app-banip: fix remaining css issues

luci-app-banip: fix remaining css issues

* fix IE Edge rendering issues
* merge remaining external styles in central css

Signed-off-by: Dirk Brenken <redacted>

luci-app-travelmate: consolidate css

* fix IE Edge rendering issues
* merge external styles in central css

Signed-off-by: Dirk Brenken <redacted>

luci-app-adblock: consolidate css

* fix IE Edge rendering issues
* merge external styles in central css

Signed-off-by: Dirk Brenken <redacted>

luci-base: allow optional default value for file browser

With this change we could set optional value for the file browser.

Signed-off-by: Florian Eckert <redacted>

luci-app-mwan3: remove deprecated local_source option

Remove deprecated local_source option which is not supported/needed anymore.

Signed-off-by: Florian Eckert <redacted>

luci-app-mwan3: add rt_table_lookup option

Make list option rt_table_lookup configurable in luci.
With this option we could define additional routing tables which get
scanned by mwan3 and then get added to the connected ipset.
The entries will be treated as connected network and will not get
mangeld by mwan3.

Signed-off-by: Florian Eckert <redacted>

luci-app-mwan3: add rtmon interval option

Add the configuration option rtmon to luci.
With this parameter we could adjust how often the routing table get
synced between main routing table and the interface routing table.

Signed-off-by: Florian Eckert <redacted>

luci-app-mwan3: rename variable in globalsconfig.lua

Name variables as the options name in uci.

Signed-off-by: Florian Eckert <redacted>

luci-app-mwan3: declare variables in globalsconfig.lua local

It is best practice to declar module variables local.

Signed-off-by: Florian Eckert <redacted>

Merge pull request #2279 from yglb/master

luci-theme-rosy: Remove redundant statements and fixed typo

luci-theme-rosy: fixed typo

Signed-off-by: Yanlan Shen <redacted>

luci-theme-rosy: Remove redundant statements

Signed-off-by: Yanlan Shen <redacted>

i18n: luci-base: update Simplified Chinese translation

Signed-off-by: Zheng Qian <redacted>

Merge pull request #2245 from Ansuel/fstab

luci-mod-system: add support for additional filesystem

luci-mod-system: add support for additional filesystem

The filesystem option doesn't include additional filesystem included with /etc/filesystems, this is usefull if someone have ntfs-3g installed and wants to force use the external utility to mount partition instead of the default present in the kernel (if it's supported)

Signed-off-by: Ansuel Smith <redacted>

Merge pull request #2275 from musashino205/l10n/tmate-upd-ja

luci-app-travelmate: update Japanese translation

luci-app-travelmate: update Japanese translation

Updated Japanese translations.

Signed-off-by: INAGAKI Hiroshi <redacted>

luci-mod-admin-full: dnsmasq clarify non-wildcard mode

'non-wildcard' interfaces enables dnsmasq's '--bind-dynamic' mode.
This binds dynamically to interfaces rather than wildcard addresses
*and* keeps track of interface comings/goings via a unique Linux api.

Quoting dnsmasq's author "bind-dynamic (bind individual addresses,
keep up with changes in interface config) ... On linux, there's actually
no sane reason not to use --bind-dynamic, and it's only not the default
for historical reasons."

listen/exclude interfaces may be used independently of bind dynamic mode
so removed the bogus dependency of 'nonwildcard' enabling access to
'listen/exclude' interfaces - they may be used in any mode..  In fact
the dnsmasq init script takes notice of include/exclude interfaces
irrespective of the 'nonwildcard' parameter.

Signed-off-by: Kevin Darbyshire-Bryant <redacted>

Merge pull request #2274 from TDT-AG/pr/20181112-luic-mod-system

luci-mod-system: add user defined interface to netdev trigger

luci-mod-system: add user defined interface to netdev trigger

Give the user the possibility to define and interface for the netdev
trigger which is not available at the moment. This is usefull if a
interface is not presented on configuration time.

Signed-off-by: Florian Eckert <redacted>

Merge pull request #2272 from dibdot/banip

luci-app-banip: fix JS errors in chromium

luci-app-banip: fix JS errors in chromium

* fix JS errors in chromium on ipset- & ripe-view page

Signed-off-by: Dirk Brenken <redacted>

Merge pull request #2262 from yglb/master

luci-theme-rosy

luci-app-olsr: convert olsr.lua and smartgw.htm to new json plugin

Signed-off-by: pmelange <redacted>

luci-app-olsr: convert mid.htm to new json plugin

Signed-off-by: pmelange <redacted>

Merge pull request #2268 from hnyman/rrd

luci-app-statistics: remove old deprecated rrdtool po files

luci-app-statistics: remove old deprecated rrdtool po files

Remove old rrdtool.po* files that have been deprecated already
in 2011-2015.

Also remove reference to them from i18n-sync.pl

Signed-off-by: Hannu Nyman <redacted>

Merge pull request #2264 from dibdot/banip

luci-app-banip: new package

Merge pull request #2267 from musashino205/l10n/base-upd-ja_2

luci-base: fix issues and update Japanese translation

luci-base: update Japanese translation

Updated Japanese translations.

Signed-off-by: INAGAKI Hiroshi <redacted>

luci-base: sync translations

Signed-off-by: INAGAKI Hiroshi <redacted>

luci-base: fix translation issues

Fixed several issues for translation.

- add translation markup to "Expecting "
- add missing ")" into "valid time (HH:MM:SS"

Signed-off-by: INAGAKI Hiroshi <redacted>

i18n: cleanup old strings

also sync translations

Signed-off-by: Hannu Nyman <redacted>

luci-app-travelmate: further translation fixup

Signed-off-by: Hannu Nyman <redacted>

Merge pull request #2265 from danrl/dm

luci-*-wireguard: Remove inactive maintainer

luci-*-wireguard: Remove inactive maintainer

I tried to find a successor in the last months, but that failed.

Signed-off by Dan Luedtke <redacted>

luci-app-banip: new package

for details & LuCI screenshots see base package desprition/PR:
https://github.com/openwrt/packages/pull/7373

Signed-off-by: Dirk Brenken <redacted>

luci-theme-rosy: Bug fix for network-interfaces

Signed-off-by: Yanlan Shen <redacted>

luci-theme-rosy: Fix resolution-related styles

Signed-off-by: Yanlan Shen <redacted>

luci-theme-rosy: Modify the layout of the header and footer

Signed-off-by: Yanlan Shen <redacted>

luci-theme-rosy: Add a background picture

Signed-off-by: Yanlan Shen <redacted>

luci-app-olsr: convert interfaces.htm to new json plugin

Signed-off-by: pmelange <redacted>

luci-app-olsr: convert olsr.lua and overview.htm to new json plugin

Signed-off-by: pmelange <redacted>

luci-base: network.lua add ipv6-prefix-assignment support to get_status_by_address

Signed-off-by: pmelange <redacted>

luci-app-olsr: cbi remove library version numbers in library search results

Signed-off-by: pmelange <redacted>

i18n: sync translations, add location annotatations

Thanks to a recent commit, the translation files will now
have info about locations where the string is used. That
can help is deciding the correct translation, as all contexts
are more easily found.

Signed-off-by: Hannu Nyman <redacted>

luci-app-nft-qos: remove extra .po files

Signed-off-by: Hannu Nyman <redacted>

Merge pull request #1855 from rosysong/nqos

luci-app-nft-qos: add new application

luci-app-nft-qos: add new application

This application is for nft-qos package.

Signed-off-by: Rosy Song <redacted>

luci-mod-network: move AHCP protocol model to AHCP application

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: validate DHCP clientid as hexstring

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: add client-side hexstring datatype validator

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: add heuristics to attribute handling in E()

If a given attribute value is a function, register it as event listener,
if it is an object, filter it through JSON.stringify(), else set it
as-is.

This helps to reduce some boiler-plate code when building DOM structures.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-material: add invalid input class

Fixes #1070.
Signed-off-by: Jo-Philipp Wich <redacted>

luci-base, themes: rework dynlist and dropdown widgets

Signed-off-by: Jo-Philipp Wich <redacted>

luci-theme-bootstrap: add flash animation

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: rework dropdown implementation

 - Refactor event handler closures into class methods and bind them instead
 - Fix quirk in dropdown placement calculation
 - Different dropdown placement strategy on touch devices
 - Broadcast custom "cbi-dropdown-change" event when value is changed
 - Implement setValues() method to alter dropdown selection
 - Prevent creating empty custom values

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: utilize node.closest() if available

Use node.closest() in findParent() when available since it should be faster
than manaually traversing the ancestor chain.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: drop cbi_bind()

Just use node.addEventListener() directly since all reasonably recent
browsers support it nowadays.

Signed-off-by: Jo-Philipp Wich <redacted>

luci-base: cbi.js: rework client side input validation

 - Refactor and fix datatype validation functions
 - Turn the type compilation and validation into a proper class
 - Display tooltip with error hint on invalid inputs

Signed-off-by: Jo-Philipp Wich <redacted>