From: Rene Scharfe <redacted>
Date: Wed, 30 Aug 2017 17:49:40 +0000 (+0200)
Subject: convert: release strbuf on error return in filter_buffer_or_fd()
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=f31f1d395131f84acbee14f42af8f702bca14468;p=git.git

convert: release strbuf on error return in filter_buffer_or_fd()

Signed-off-by: Rene Scharfe <redacted>
Signed-off-by: Junio C Hamano <redacted>
---

diff --git a/convert.c b/convert.c
index c5f0b21037..4a0ed8d3cb 100644
--- a/convert.c
+++ b/convert.c
@@ -423,8 +423,10 @@ static int filter_buffer_or_fd(int in, int out, void *data)
 	child_process.in = -1;
 	child_process.out = out;
 
-	if (start_command(&child_process))
+	if (start_command(&child_process)) {
+		strbuf_release(&cmd);
 		return error("cannot fork to run external filter '%s'", params->cmd);
+	}
 
 	sigchain_push(SIGPIPE, SIG_IGN);