From: Paul Donald <redacted>
Date: Wed, 4 Mar 2026 00:13:00 +0000 (+0100)
Subject: luci-base: prevent save/traceback race for _state
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=daca0e85a8d4b4ce91c545bd44aa636224b2c87d;p=openwrt-luci.git

luci-base: prevent save/traceback race for _state

A _state race is possible during save when a refresh is in
progress. Attempt to avoid it by not nulling state prior
to refresh.

Signed-off-by: Paul Donald <redacted>
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/network.js b/modules/luci-base/htdocs/luci-static/resources/network.js
index 6d84f12a5f..67ed3bf522 100644
--- a/modules/luci-base/htdocs/luci-static/resources/network.js
+++ b/modules/luci-base/htdocs/luci-static/resources/network.js
@@ -354,7 +354,6 @@ function initNetworkState(refresh) {
 	if (_state == null || refresh) {
 		const hasWifi = L.hasSystemFeature('wifi');
 
-		if (refresh) _state = null;
 		if (refresh || !_init) {
 			_init = Promise.all([
 			L.resolveDefault(callNetworkInterfaceDump(), []),
@@ -538,6 +537,9 @@ function initNetworkState(refresh) {
 
 	}
 
+	if (refresh)
+		return _init;
+
 	return (_state != null ? Promise.resolve(_state) : _init);
 }