From: Jo-Philipp Wich <redacted>
Date: Sun, 27 Feb 2022 19:33:02 +0000 (+0100)
Subject: luci-base: ui: fix null access in ui.Table.update()
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=d29400ea09c7de234aa9ce580c1f0567b20ec65e;p=openwrt-luci.git

luci-base: ui: fix null access in ui.Table.update()

Fixes: #5702
Fixes: e0e6989a4a ("luci-base: introduce new LuCI.ui.Table class")
Signed-off-by: Jo-Philipp Wich <redacted>
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js
index f915afdc3a..5abd3b388d 100644
--- a/modules/luci-base/htdocs/luci-static/resources/ui.js
+++ b/modules/luci-base/htdocs/luci-static/resources/ui.js
@@ -3256,7 +3256,7 @@ var UITable = baseclass.extend(/** @lends LuCI.ui.table.prototype */ {
 		}
 
 		while (rows[++n])
-			target.removeChild(rows[n]);
+			this.node.removeChild(rows[n]);
 
 		if (placeholder && this.node.firstElementChild === this.node.lastElementChild) {
 			var trow = this.node.appendChild(E('tr', { 'class': 'tr placeholder' })),