From: Dirk Brenken <redacted>
Date: Fri, 12 Jun 2026 20:32:47 +0000 (+0200)
Subject: luci-app-banip: release 1.8.9-1
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=c7b95dc2d7d7c67aed6b9009ecf6538d8a674762;p=openwrt-luci.git

luci-app-banip: release 1.8.9-1

* fix minor code issues

Signed-off-by: Dirk Brenken <redacted>
---

diff --git a/applications/luci-app-banip/Makefile b/applications/luci-app-banip/Makefile
index 74d83aa2dd..b6eefd9c18 100644
--- a/applications/luci-app-banip/Makefile
+++ b/applications/luci-app-banip/Makefile
@@ -6,8 +6,8 @@ include $(TOPDIR)/rules.mk
 LUCI_TITLE:=LuCI support for banIP
 LUCI_DEPENDS:=+luci-base +banip
 
-PKG_VERSION:=1.8.8
-PKG_RELEASE:=5
+PKG_VERSION:=1.8.9
+PKG_RELEASE:=1
 PKG_LICENSE:=Apache-2.0
 PKG_MAINTAINER:=Dirk Brenken <dev@brenken.org>
 
diff --git a/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/feeds.js b/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/feeds.js
index e49cafd3e3..412c31021a 100644
--- a/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/feeds.js
+++ b/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/feeds.js
@@ -73,11 +73,11 @@ observer.observe(targetNode, observerConfig);
 function handleEdit(ev) {
 	if (ev === 'upload') {
 		return ui.uploadFile('/etc/banip/banip.custom.feeds').then(function () {
-			L.resolveDefault(fs.read_direct('/etc/banip/banip.custom.feeds', 'json'), "").then(function (data) {
+			return L.resolveDefault(fs.read_direct('/etc/banip/banip.custom.feeds', 'json'), "").then(function (data) {
 				if (data && Object.keys(data).length > 0) {
 					for (let i = 0; i < Object.keys(data).length; i++) {
 						let feed = Object.keys(data)[i];
-						let descr = data[feed].descr;
+						let descr = data[feed]?.descr;
 						if (feed && descr) {
 							continue;
 						}
diff --git a/applications/luci-app-banip/root/usr/share/rpcd/acl.d/luci-app-banip.json b/applications/luci-app-banip/root/usr/share/rpcd/acl.d/luci-app-banip.json
index c25476a2d4..6ab134fd38 100644
--- a/applications/luci-app-banip/root/usr/share/rpcd/acl.d/luci-app-banip.json
+++ b/applications/luci-app-banip/root/usr/share/rpcd/acl.d/luci-app-banip.json
@@ -65,9 +65,6 @@
 				],
 				"/etc/init.d/banip content *": [
 					"exec"
-				],
-				"/etc/init.d/banip status": [
-					"exec"
 				]
 			},
 			"uci": [