From: Oever González <redacted>
Date: Sun, 1 Sep 2019 05:02:04 +0000 (-0600)
Subject: samba4: remove double quotes for renice
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=c45974d0a32498810f305cb26746f45045b38008;p=openwrt-packages.git

samba4: remove double quotes for renice

The double quote thells the shell that the list returned from `pidof` is a
single argument, therefore, `renice` will cry about a malformed input.
With this commit, `renice` will be applied correctly to all the returned PIDs
from `pidof`.

The output of `renice` for the quoted list is as follows:
`renice: invalid number '6592 6587 6586 6574'`
`renice` does not show and does apply the nice value if the list is unquoted.

Signed-off-by: Oever González <redacted>
Signed-off-by: Jan Pavlinec <redacted>
---

diff --git a/net/samba4/files/samba.init b/net/samba4/files/samba.init
index d7eed562a..39686e6cd 100644
--- a/net/samba4/files/samba.init
+++ b/net/samba4/files/samba.init
@@ -211,9 +211,9 @@ start_service() {
 	fi
 	# lower priority using renice (if found)
 	if [ -x /usr/bin/renice ]; then
-		[ -x /usr/sbin/samba ] && renice -n 2 "$(pidof samba)"
-		[ -x /usr/sbin/smbd ] && renice -n 2 "$(pidof smbd)"
-		[ -x /usr/sbin/nmbd ] && renice -n 2 "$(pidof nmbd)"
-		[ -x /usr/sbin/winbindd ] && renice -n 2 "$(pidof winbindd)"
+		[ -x /usr/sbin/samba ] && renice -n 2 $(pidof samba)
+		[ -x /usr/sbin/smbd ] && renice -n 2 $(pidof smbd)
+		[ -x /usr/sbin/nmbd ] && renice -n 2 $(pidof nmbd)
+		[ -x /usr/sbin/winbindd ] && renice -n 2 $(pidof winbindd)
 	fi
 }