From: Eric McDonald <redacted>
Date: Sat, 7 Mar 2026 21:45:22 +0000 (-0800)
Subject: net-snmp: add early return when Mode is unset
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=c3862ec354ab7957a54bffc8af4fe2b27b84eb13;p=openwrt-packages.git

net-snmp: add early return when Mode is unset

snmpd_access_default_add, snmpd_access_HostName_add, and
snmpd_access_HostIP_add would write unintended output to the
config file if the Mode option is not specified. Add an early
return to each function to prevent writing in that case.

This is a breaking change for configs where Mode is unset.
Previously, an empty Mode option would result in a malformed
directive with a leading space and no guaranteed newline, the
exact form of which depended on the values of other options.
Now, no directive is written.

Signed-off-by: Eric McDonald <redacted>
---

diff --git a/net/net-snmp/files/snmpd.init b/net/net-snmp/files/snmpd.init
index 78df7c9a2..bc675792d 100644
--- a/net/net-snmp/files/snmpd.init
+++ b/net/net-snmp/files/snmpd.init
@@ -130,6 +130,7 @@ snmpd_trap_ip_add() {
 snmpd_access_default_add() {
 	local cfg="$1"
 	config_get mode "$cfg" Mode
+	[ -n "$mode" ] || return 0
 	config_get community "$cfg" CommunityName
 	config_get oidrestrict "$cfg" RestrictOID
 	config_get oid "$cfg" RestrictedOID
@@ -142,6 +143,7 @@ snmpd_access_HostName_add() {
 	local cfg="$1"
 	config_get hostname "$cfg" HostName
 	config_get mode "$cfg" Mode
+	[ -n "$mode" ] || return 0
 	config_get community "$cfg" CommunityName
 	config_get oidrestrict "$cfg" RestrictOID
 	config_get oid "$cfg" RestrictedOID
@@ -155,6 +157,7 @@ snmpd_access_HostIP_add() {
 	config_get host_ip "$cfg" HostIP
 	config_get ip_mask "$cfg" IPMask
 	config_get mode "$cfg" Mode
+	[ -n "$mode" ] || return 0
 	config_get community "$cfg" CommunityName
 	config_get oidrestrict "$cfg" RestrictOID
 	config_get oid "$cfg" RestrictedOID