From: Denton Liu <redacted>
Date: Fri, 20 Dec 2019 18:15:48 +0000 (-0800)
Subject: t/lib-git-p4: use test_path_is_missing()
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=b8afb908c261752310d4792f901c68fe27b77b40;p=git.git

t/lib-git-p4: use test_path_is_missing()

Previously, cleanup_git() would use `test_must_fail test -d` to ensure
that the directory is removed. However, test_must_fail should only be
used for git commands. Use test_path_is_missing() instead to check that
the directory has been removed.

Signed-off-by: Denton Liu <redacted>
Signed-off-by: Junio C Hamano <redacted>
---

diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 547b9f88e1..5aff2abe8b 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -175,7 +175,7 @@ stop_and_cleanup_p4d () {
 
 cleanup_git () {
 	retry_until_success rm -r "$git"
-	test_must_fail test -d "$git" &&
+	test_path_is_missing "$git" &&
 	retry_until_success mkdir "$git"
 }