From: Alexandru Ardelean <redacted>
Date: Wed, 14 Mar 2018 14:21:40 +0000 (+0200)
Subject: python,python3: remove `--with-system-ffi=no` config arg
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=b6973e5deb5a3172f303f4717e039bcb79c49469;p=openwrt-packages.git

python,python3: remove `--with-system-ffi=no` config arg

Report https://github.com/openwrt/packages/issues/5638
It was mentioned that this causes build failures on Mac OS X.

The default behavior [in the setup.py script] is to check whether
`--with-system-ffi` is present in the CONFIG_ARGS env var.

However that back-fires a bit when `--with-system-ffi=no`, because the
condition `not '--with-system-ffi' in sysconfig.get_config_var("CONFIG_ARGS")`
evaluates to true.

This is a small bug in the `setup.py` script, but it looks like the
easiest/cleanest way to address it on our end is to just remove it entirely
from the HOST_CONFIGURE_ARGS.
At least that's how it looks like when testing on a Linux machine.

Signed-off-by: Alexandru Ardelean <redacted>
---

diff --git a/lang/python/python/Makefile b/lang/python/python/Makefile
index 5f698888a..0948e3500 100644
--- a/lang/python/python/Makefile
+++ b/lang/python/python/Makefile
@@ -282,7 +282,6 @@ HOST_CONFIGURE_ARGS+= \
 	--prefix=$(HOST_PYTHON_DIR) \
 	--exec-prefix=$(HOST_PYTHON_DIR) \
 	--with-system-expat=$(STAGING_DIR_HOSTPKG) \
-	--with-system-ffi=no \
 	--with-ensurepip=install \
 	CONFIG_SITE=
 
diff --git a/lang/python/python3/Makefile b/lang/python/python3/Makefile
index 794a2bf75..85952c298 100644
--- a/lang/python/python3/Makefile
+++ b/lang/python/python3/Makefile
@@ -278,7 +278,6 @@ HOST_CONFIGURE_ARGS+= \
 	--prefix=$(HOST_PYTHON3_DIR) \
 	--exec-prefix=$(HOST_PYTHON3_DIR) \
 	--with-system-expat=$(STAGING_DIR_HOSTPKG) \
-	--with-system-ffi=no \
 	--with-ensurepip=install \
 	CONFIG_SITE=