From: Satadru Pramanik, DO, MPH, MEng <redacted>
Date: Wed, 3 Sep 2025 15:23:23 +0000 (-0400)
Subject: acme-common: cleanup acme start crontab migration
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=b3098fe68a0559b8a8958f2ec1a537d7468ad72c;p=openwrt-packages.git

acme-common: cleanup acme start crontab migration

The '/etc/init.d/acme start' crontab migration
should also delete the existing
'/etc/init.d/acme start' line.

Otherwise, on every sysupgrade that carries
forward existing configurations, a new
'0 0 * * * /etc/init.d/acme renew' line is
added to the crontab.

Furthermore, do not add an 'acme renew' crontab
line if it already exists.

Signed-off-by: Satadru Pramanik, DO, MPH, MEng <redacted>
---

diff --git a/net/acme-common/Makefile b/net/acme-common/Makefile
index e05b943c9..f8f489814 100644
--- a/net/acme-common/Makefile
+++ b/net/acme-common/Makefile
@@ -8,7 +8,7 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=acme-common
-PKG_VERSION:=1.4.3
+PKG_VERSION:=1.4.4
 
 PKG_MAINTAINER:=Toke Høiland-Jørgensen <toke@toke.dk>
 PKG_LICENSE:=GPL-3.0-only
diff --git a/net/acme-common/files/acme.uci-defaults b/net/acme-common/files/acme.uci-defaults
index bf1bcb10f..326f1e8c1 100644
--- a/net/acme-common/files/acme.uci-defaults
+++ b/net/acme-common/files/acme.uci-defaults
@@ -55,7 +55,8 @@ uci_commit
 
 # Migrate '/etc/init.d/acme start' to '/etc/init.d/acme renew'
 grep -q '/etc/init.d/acme start' /etc/crontabs/root 2>/dev/null && {
-	echo "0 0 * * * /etc/init.d/acme renew" >>/etc/crontabs/root
+	grep -q '/etc/init.d/acme' /etc/crontabs/root 2>/dev/null || echo "0 0 * * * /etc/init.d/acme renew" >>/etc/crontabs/root
+	sed '/0 0 * * * \/etc\/init.d\/acme start/d' /etc/crontabs/root
 }
 
 exit 0