From: Thibaut VARÈNE <redacted>
Date: Thu, 27 Jan 2022 10:14:58 +0000 (+0100)
Subject: coova-chilli: remove hotplug call
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=a3e125267ca4f9f1752ebdd6525c0c3246bfc600;p=openwrt-packages.git

coova-chilli: remove hotplug call

This hotplug trigger unconditionaly restarts coova-chilli when the "wan"
interface sees action "ifup", without checking whether or not the
service is disabled or the upstream interface is actually called "wan".

This hotplug could be replaced by a suitable service trigger instead.

Signed-off-by: Thibaut VARÈNE <redacted>
---

diff --git a/net/coova-chilli/Makefile b/net/coova-chilli/Makefile
index 47c11ad14..a4f1db7e0 100644
--- a/net/coova-chilli/Makefile
+++ b/net/coova-chilli/Makefile
@@ -132,8 +132,6 @@ define Package/coova-chilli/install
 	$(INSTALL_CONF) $(PKG_INSTALL_DIR)/etc/chilli.conf $(1)/etc/
 	$(INSTALL_DIR) $(1)/etc/chilli
 	$(CP) $(PKG_INSTALL_DIR)/etc/chilli/* $(1)/etc/chilli/
-	$(INSTALL_DIR) $(1)/etc/hotplug.d/iface
-	$(INSTALL_DATA) ./files/chilli.hotplug $(1)/etc/hotplug.d/iface/30-chilli
 	$(INSTALL_DIR) $(1)/usr/sbin
 	$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/sbin/chilli* $(1)/usr/sbin/
 	$(INSTALL_DIR) $(1)/usr/lib/
diff --git a/net/coova-chilli/files/chilli.hotplug b/net/coova-chilli/files/chilli.hotplug
deleted file mode 100644
index e12812b49..000000000
--- a/net/coova-chilli/files/chilli.hotplug
+++ /dev/null
@@ -1,7 +0,0 @@
-#!/bin/sh
-
-[ "$ACTION" == "ifup" ] || exit 0
-
-[ "$INTERFACE" = "wan" ] && {
-	/etc/init.d/chilli restart
-}