From: Jo-Philipp Wich <redacted>
Date: Wed, 1 Apr 2026 11:11:14 +0000 (+0200)
Subject: luci-base: fix ubus getFeatures() crash
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=95a84c0c4369cfaad6b67961b2c5e6be0870f528;p=openwrt-luci.git

luci-base: fix ubus getFeatures() crash

OpenWrt versions that provide odhcpd versions reporting a compile time
features line in their help output trigger a crash in the getFeatures()
procedure (attempt to set property on boolean value) - fix this issue
by not predeclaring the odhcpd flag as `false`.

Fixes: #8489
Fixes: 0529dca7a2 ("luci-base: fix feature detection patterns")
Signed-off-by: Jo-Philipp Wich <redacted>
---

diff --git a/modules/luci-base/root/usr/share/rpcd/ucode/luci b/modules/luci-base/root/usr/share/rpcd/ucode/luci
index 511853cd71..ca95ded897 100644
--- a/modules/luci-base/root/usr/share/rpcd/ucode/luci
+++ b/modules/luci-base/root/usr/share/rpcd/ucode/luci
@@ -291,7 +291,6 @@ const methods = {
 				fd.close();
 			}
 
-			result.odhcpd = false;
 			fd = popen('odhcpd -h 2>/dev/null');
 
 			if (fd) {