From: funilrys Date: Fri, 2 Mar 2018 21:53:15 +0000 (+0100) Subject: Review of Notes indentation X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=6e62383b28a278e824eb70606dfc6d78d3bfdbfe;p=stevenblack-hosts.git Review of Notes indentation This patch fix : https://github.com/StevenBlack/hosts/pull/520#discussion_r171971481 + It also fix (forgoten coma) : https://github.com/StevenBlack/hosts/pull/520#discussion_r171971574 --- diff --git a/updateHostsFile.py b/updateHostsFile.py index 3231e954e..a350ac08b 100644 --- a/updateHostsFile.py +++ b/updateHostsFile.py @@ -1147,12 +1147,12 @@ def domain_to_idna(line): Notes ----- - This function encode only the domain to `idna` format because in - most cases the encoding issue is due to a domain which looks like + most cases, the encoding issue is due to a domain which looks like `b'\xc9\xa2oogle.com'.decode('idna')`. - About the splitting: We split because we only want to encode the domain and not the full - line which may cause some issue. Keep in mind that we split but we - still concatenate once we encoded the domain. + line which may cause some issue. Keep in mind that we split but we + still concatenate once we encoded the domain. - The following split the prefix `0.0.0.0` or `127.0.0.1` of a line. - The following also split the trailing comment of a given line.