From: Paul Donald <redacted>
Date: Sat, 30 Nov 2024 18:16:11 +0000 (+0100)
Subject: ddns-scripts: variable quoting
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=6706a5bd78c19ed256a51909c63e7f9718210543;p=openwrt-packages.git

ddns-scripts: variable quoting

in case spaces should creep into path names

Signed-off-by: Paul Donald <redacted>
---

diff --git a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_lucihelper.sh b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_lucihelper.sh
index f76334848..c57e1cf39 100644
--- a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_lucihelper.sh
+++ b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_lucihelper.sh
@@ -147,19 +147,19 @@ case "$1" in
 		;;
 	start)
 		[ -z "$SECTION" ] &&  usage_err "command 'start': 'SECTION' not set"
-		if [ $VERBOSE -eq 0 ]; then	# start in background
-			$DDNSPRG -v 0 -S $SECTION -- start &
+		if [ "$VERBOSE" -eq 0 ]; then	# start in background
+			"$DDNSPRG" -v 0 -S "$SECTION" -- start &
 		else
-			$DDNSPRG -v $VERBOSE -S $SECTION -- start
+			"$DDNSPRG" -v "$VERBOSE" -S "$SECTION" -- start
 		fi
 		;;
 	reload)
-		$DDNSPRG -- reload
+		"$DDNSPRG" -- reload
 		;;
 	restart)
-		$DDNSPRG -- stop
+		"$DDNSPRG" -- stop
 		sleep 1
-		$DDNSPRG -- start
+		"$DDNSPRG" -- start
 		;;
 	*)
 		__RET=255
@@ -167,6 +167,6 @@ case "$1" in
 esac
 
 # remove out and err file
-[ -f $DATFILE ] && rm -f $DATFILE
-[ -f $ERRFILE ] && rm -f $ERRFILE
+[ -f "$DATFILE" ] && rm -f "$DATFILE"
+[ -f "$ERRFILE" ] && rm -f "$ERRFILE"
 return $__RET