From: Jo-Philipp Wich <redacted>
Date: Wed, 12 May 2021 09:49:31 +0000 (+0200)
Subject: luci-mod-status: fix potential XSS via specially crafted DNS names
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=3c66c5b1651aa25afbff09bee45047da9a0ba43d;p=openwrt-luci.git

luci-mod-status: fix potential XSS via specially crafted DNS names

When an upstream NS returns PTR domain names containing HTML, it is
added verbatim to the connection status table.

Prevent this issue by HTML escaping any values in the source and
destination columns.

Fixes: CVE-2021-32019
Signed-off-by: Jo-Philipp Wich <redacted>
---

diff --git a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
index 9d97569d22..a87fe53fed 100644
--- a/modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
+++ b/modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
@@ -133,8 +133,8 @@ return view.extend({
 			rows.push([
 				c.layer3.toUpperCase(),
 				c.layer4.toUpperCase(),
-				c.hasOwnProperty('sport') ? (src + ':' + c.sport) : src,
-				c.hasOwnProperty('dport') ? (dst + ':' + c.dport) : dst,
+				'%h'.format(c.hasOwnProperty('sport') ? (src + ':' + c.sport) : src),
+				'%h'.format(c.hasOwnProperty('dport') ? (dst + ':' + c.dport) : dst),
 				'%1024.2mB (%d %s)'.format(c.bytes, c.packets, _('Pkts.'))
 			]);
 		}