From: Daniel F. Dickinson <redacted>
Date: Thu, 1 Jan 2026 06:24:17 +0000 (-0500)
Subject: php8: fix xmlreader dom circular dependency
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=247c1a196496015158b9cc3ee8ff83cf0101b26b;p=openwrt-packages.git

php8: fix xmlreader dom circular dependency

xmlreader was selecting package php8-mod-dom as well as depending on
PHP8_DOM, while php8-mod-dom also depended on PHP8_DOM (and therefore
selected PHP8_DOM when php8-mod-dom was selected). This is a Kconfig
recursive dependency, so break the recursion by noting that because
php8-mod-xmlreader selects php8-mod-dom, PHP8_DOM is a transitive
depends, so php8-mod-xmlreader should not depend on PHP8_DOM itself.

Signed-off-by: Daniel F. Dickinson <redacted>
---

diff --git a/lang/php8/Config.in b/lang/php8/Config.in
index 5859b056e..fa277c99e 100644
--- a/lang/php8/Config.in
+++ b/lang/php8/Config.in
@@ -9,6 +9,11 @@ config PHP8_DOM
 	bool "PHP8 DOM support"
 	depends on PHP8_LIBXML
 	default y
+	help
+	  Without php8-mod-dom, this option does not provide a PHP8
+	  programmer the XML DOM functionality (it only adds DOM for internal
+	  use by php-cli, php-cgi, etc.). Therefore please consider adding
+	  php8-mod-dom to provide this functionality to PHP8 consumers.
 
 config PHP8_SYSTEMTZDATA
 	bool "Use system timezone data instead of php's built-in database"
diff --git a/lang/php8/Makefile b/lang/php8/Makefile
index 9ed165e2c..42eb7eb46 100644
--- a/lang/php8/Makefile
+++ b/lang/php8/Makefile
@@ -677,6 +677,6 @@ $(eval $(call BuildModule,sysvsem,System V shared memory))
 $(eval $(call BuildModule,sysvshm,System V semaphore))
 $(eval $(call BuildModule,tokenizer,Tokenizer))
 $(eval $(call BuildModule,xml,XML,+PHP8_LIBXML:libxml2 +!PHP8_LIBXML:libexpat))
-$(eval $(call BuildModule,xmlreader,XMLReader,@PHP8_LIBXML @PHP8_DOM +PACKAGE_php8-mod-xmlreader:php8-mod-dom +PACKAGE_php8-mod-xmlreader:libxml2))
+$(eval $(call BuildModule,xmlreader,XMLReader,@PHP8_LIBXML +PACKAGE_php8-mod-xmlreader:php8-mod-dom +PACKAGE_php8-mod-xmlreader:libxml2))
 $(eval $(call BuildModule,xmlwriter,XMLWriter,@PHP8_LIBXML +PACKAGE_php8-mod-xmlwriter:libxml2))
 $(eval $(call BuildModule,zip,ZIP,+PACKAGE_php8-mod-zip:libzip))