From: Kim Slawson <redacted>
Date: Sun, 3 Mar 2013 05:41:03 +0000 (-0500)
Subject: Optimize sub-optimal way of doing acrostics. (Is unnecessary optimization worse than... 
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=23e25bf7fc4d390c559c6990753c727ecd81258d;p=redacted-XKCD-password-generator.git

Optimize sub-optimal way of doing acrostics. (Is unnecessary optimization worse than premature optimization?)
---

diff --git a/xkcd-password.py b/xkcd-password.py
index 4427cb0..c37ec94 100755
--- a/xkcd-password.py
+++ b/xkcd-password.py
@@ -165,15 +165,15 @@ def generate_xkcdpassword(wordlist, n_words=4, interactive=False, acrostic=False
 	    return " ".join(rng().sample(wordlist, n_words))
         else:
             """
-            # slower but more elegant
+            # slower but more elegant. "pythonic"
             while 1:
                 words = " ".join(rng().sample(wordlist, n_words))
-                if acrostic.lower() == "".join(item[0].lower() for item in words.split()):
+                if acrostic.lower() == "".join(item[0] for item in words.split()).lower():
                     return words
                     break
             """
 
-            # faster but less elegant
+            # faster but less elegant. practical.
             words = ""
             for letter in acrostic:
                 while 1: