From: Max G Date: Sat, 11 Jul 2020 10:57:42 +0000 (+0300) Subject: Revert "Implemented connectivity check (Fixed #1038)" X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=0f727b8bedce24cf50ed2fd6d6b31611dca7257b;p=stevenblack-hosts.git Revert "Implemented connectivity check (Fixed #1038)" This reverts commit bc8e4c92b85f911a25d0678468c9bad0ce806168. --- diff --git a/updateHostsFile.py b/updateHostsFile.py index 64d3a6a20..8eaff1717 100644 --- a/updateHostsFile.py +++ b/updateHostsFile.py @@ -242,8 +242,7 @@ def main(): update_sources = prompt_for_update(freshen=settings["freshen"], update_auto=auto) if update_sources: - if await_network_connection(): - update_all_sources(source_data_filename, settings["hostfilename"]) + update_all_sources(source_data_filename, settings["hostfilename"]) gather_exclusions = prompt_for_exclusions(skip_prompt=auto) @@ -326,34 +325,6 @@ def main(): flush_cache=settings["flushdnscache"], prompt_flush=not auto ) -def await_network_connection(retries=3, delay=10): - """ - Check if we have a proper name resolution and connectivity - By pinging a common domain - - Parameters - ---------- - retries : int - Number of times to retry again (on ping failure) - delay : int - How many seconds to wait before retrying again (on ping failure) - - Returns - ------- - -> bool - True : A ping succeded - False : All retries have failed - """ - while retries: - if 0 == subprocess.call(['ping', 'one.one.one.one', '-c', '1'], - stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL): - return True - - print(f'No internet connection! Retrying in {delay} seconds') - time.sleep(delay) - retries -= 1 - return False - # Prompt the User def prompt_for_update(freshen, update_auto):