From: Dennis van de Hoef <redacted>
Date: Fri, 26 May 2023 15:38:29 +0000 (+0200)
Subject: Make sure to close files
X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=0ea9a40158ed6e937032ad577f7de83959f345f3;p=stevenblack-hosts.git

Make sure to close files
---

diff --git a/updateHostsFile.py b/updateHostsFile.py
index fc6bf1915..5c8271492 100755
--- a/updateHostsFile.py
+++ b/updateHostsFile.py
@@ -695,9 +695,11 @@ def update_sources_data(sources_data, **sources_params):
             recursive_glob(sources_params["datapath"], source_data_filename)
         ):
             update_file = open(source, "r", encoding="UTF-8")
-            update_data = json.load(update_file)
-            sources_data.append(update_data)
-            update_file.close()
+            try:
+                update_data = json.load(update_file)
+                sources_data.append(update_data)
+            finally:
+                update_file.close()
 
     for source in sources_params["extensions"]:
         source_dir = path_join_robust(sources_params["extensionspath"], source)
@@ -705,10 +707,11 @@ def update_sources_data(sources_data, **sources_params):
             recursive_glob(source_dir, source_data_filename)
         ):
             update_file = open(update_file_path, "r")
-            update_data = json.load(update_file)
-
-            sources_data.append(update_data)
-            update_file.close()
+            try:
+                update_data = json.load(update_file)
+                sources_data.append(update_data)
+            finally:
+                update_file.close()
 
     return sources_data