From: PeterK Date: Wed, 23 Apr 2025 10:14:38 +0000 (+0200) Subject: luci-app-banip: Trim() error fix. X-Git-Url: http://git.99rst.org/?a=commitdiff_plain;h=05b8d9b1ee98c1bd73100f7b4f038dd6e94ff88b;p=openwrt-luci.git luci-app-banip: Trim() error fix. Unable to open a banip Overview tab. Update overview.js for the Trim() error fix. Signed-off-by: PeterK --- diff --git a/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/overview.js b/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/overview.js index 09ccb231c4..47f4d9cd89 100644 --- a/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/overview.js +++ b/applications/luci-app-banip/htdocs/luci-static/resources/view/banip/overview.js @@ -695,9 +695,9 @@ return view.extend({ if (feeds && Object.keys(feeds).length) { o = s.taboption('feeds', form.MultiValue, 'ban_feed', _('Blocklist Feed')); for (let i = 0; i < Object.keys(feeds).length; i++) { - feed = Object.keys(feeds)[i].trim(); - chain = feeds[feed].chain.trim() || 'in'; - descr = feeds[feed].descr.trim() || '-'; + feed=(Object.keys(feeds)[i] || '').trim(); + chain=(feeds[feed]?.chain ||'in').trim(); + descr=(feeds[feed]?.descr || '-').trim(); o.value(feed, feed + ' (' + chain + ', ' + descr + ')'); } o.optional = true;