[newsline][crit] rewrite open; can openurl

diff --git a/_testing/config.yml b/_testing/config.yml
index 012305bb15e13f496d124b91e4690005aac0a583..2f81859e115537829e15048ad0da6b5a41cd79e6 100644 (file)
--- a/_testing/config.yml
+++ b/_testing/config.yml
@@ -47,7 +47,6 @@ whitelist:
   - l33tmusic
   - log2ansi
   - mkshorterlink
-  - newsline
   - oidenty
   - 'on'
   - osd

diff --git a/scripts/newsline.pl b/scripts/newsline.pl
index 0f54eee93956d68bdbab95c7005d6bc312d04fe4..b37cfcc6d807451ca0b2f965f9e8297e316d3d9d 100644 (file)
--- a/scripts/newsline.pl
+++ b/scripts/newsline.pl
@@ -3,7 +3,7 @@
 use strict;
 
 use vars qw($VERSION %IRSSI);
-$VERSION = '2003021101';
+$VERSION = '2017040101';
 %IRSSI = (
     authors     => 'Stefan \'tommie\' Tomanek',
     contact     => 'stefan@pico.ruhr.de',
@@ -287,10 +287,10 @@ sub call_openurl ($) {
     my ($url) = @_;
     no strict "refs";
     # check for a loaded openurl
-    if (defined %{ "Irssi::Script::openurl::" }) {
-       &{ "Irssi::Script::openurl::launch_url" }($url);
+    if (my $code = Irssi::Script::openurl::->can('launch_url')) {
+        $code->($url);
     } else {
-       print CLIENTCRAP "%R>>%n Please install openurl.pl";
+        print CLIENTCRAP "%R>>%n Please install openurl.pl";
     }
     use strict "refs";
 }
@@ -377,7 +377,7 @@ sub reload_config() {
     my $text;
     if (-e $filename) {
        local *F;
-       open F, "<".$filename;
+       open F, "<",$filename;
        $text .= $_ foreach (<F>);
        close F;
        if ($text) {
@@ -402,7 +402,7 @@ sub reload_config() {
 sub save_config() {
     local *F;
     my $filename = Irssi::settings_get_str('newsline_sites_file');
-    open(F, ">$filename");
+    open(F, '>',$filename);
     my $dumper = Data::Dumper->new([\%sites], ['sites']);
     $dumper->Purity(1)->Deepcopy(1);
     my $data = $dumper->Dump;