name-rev --all: do not even attempt to describe non-commit object

This even dates back to the very beginning of "git name-rev";
it does not make much sense to dump all objects in the repository
and label non-commits as "undefined".

Signed-off-by: Junio C Hamano <redacted>

diff --git a/builtin-name-rev.c b/builtin-name-rev.c
index 06a38ac8c10126085e6477c205d450da089faae2..eb8bf70c7001b97e3403e2d0c980c437058a459f 100644 (file)
--- a/builtin-name-rev.c
+++ b/builtin-name-rev.c
@@ -289,7 +289,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
                max = get_max_object_index();
                for (i = 0; i < max; i++) {
                        struct object *obj = get_indexed_object(i);
-                       if (!obj)
+                       if (!obj || obj->type != OBJ_COMMIT)
                                continue;
                        show_name(obj, NULL,
                                  always, allow_undefined, data.name_only);