libpqxx: fixed review comments
authorIgor Bezzubchenko <redacted>
Sat, 2 Jan 2021 19:08:18 +0000 (22:08 +0300)
committerIgor Bezzubchenko <redacted>
Sat, 2 Jan 2021 19:17:39 +0000 (22:17 +0300)
Removed PKG_INSTALL
Capitalized options
Use inline `if` instead of blocks

Signed-off-by: Igor Bezzubchenko <redacted>
libs/libpqxx/Makefile

index a9789a74be39c1ed978ee47fed182d5058e6700c..87ee10aa9029935e547352e5179a0f5f0fcadc0f 100644 (file)
@@ -3,7 +3,6 @@ include $(TOPDIR)/rules.mk
 PKG_NAME:=libpqxx
 PKG_VERSION:=7.3.0
 PKG_RELEASE:=1
-PKG_INSTALL:=1
 
 PKG_SOURCE_PROTO:=git
 PKG_SOURCE_URL:=https://github.com/jtv/libpqxx
@@ -31,15 +30,13 @@ define Package/libpqxx/config
 endef
 
 CMAKE_OPTIONS += \
-       -DBUILD_DOC=off \
-       $(if $(CONFIG_LIBPQXX_STATIC), -DBUILD_STATIC_LIBS=on) \
-       $(if $(CONFIG_LIBPQXX_SHARED), -DBUILD_SHARED_LIBS=on)
-
-ifeq ($(CONFIG_LIBPQXX_INSTALL_TEST),y)
-       CMAKE_OPTIONS += -DINSTALL_TEST=on -DSKIP_BUILD_TEST=off
-else
-       CMAKE_OPTIONS += -DINSTALL_TEST=off -DSKIP_BUILD_TEST=on
-endif
+       -DBUILD_DOC=OFF \
+       -DBUILD_STATIC_LIBS=O$(if $(CONFIG_LIBPQXX_STATIC),N,FF) \
+       -DBUILD_SHARED_LIBS=O$(if $(CONFIG_LIBPQXX_SHARED),N,FF) \
+       $(if $(CONFIG_LIBPQXX_INSTALL_TEST),\
+               -DINSTALL_TEST=ON  -DSKIP_BUILD_TEST=OFF, \
+               -DINSTALL_TEST=OFF -DSKIP_BUILD_TEST=ON \
+       )
 
 define Package/libpqxx/install
        $(INSTALL_DIR) $(1)/usr/lib
git clone https://git.99rst.org/PROJECT