[quitmsg] Update script with more modern perl

diff --git a/scripts/quitmsg.pl b/scripts/quitmsg.pl
index e289468ca2fe3412a1c0bfb620d7117513a12d76..2e943ee615949aa4a66b1c3b98c92d4518daf18c 100644 (file)
--- a/scripts/quitmsg.pl
+++ b/scripts/quitmsg.pl
@@ -6,13 +6,13 @@ use Irssi::Irc;
 use strict;
 use vars qw($VERSION %IRSSI);
 
-$VERSION = "1.00";
+$VERSION = "1.01";
 %IRSSI = (
     authors     => 'Timo Sirainen',
     name        => 'quitmsg',
     description => 'Random quit messages',
     license     => 'Public Domain',
-    changed    => 'Sun Mar 10 23:18 EET 2002'
+    changed    => 'Mon Jul 13 18:00 EET 2020'
 );
 
 my $quitfile = glob "~/.irssi/irssi.quit";
@@ -20,22 +20,13 @@ my $quitfile = glob "~/.irssi/irssi.quit";
 sub cmd_quit {
        my ($data, $server, $channel) = @_;
        return if ($data ne "");
+       
+       open (my $fh, "<", $quitfile) || return;
+       my @lines = <$fh>;
 
-       open (f, "<", $quitfile) || return;
-       my $lines = 0; while(<f>) { $lines++; };
-
-       my $line = int(rand($lines))+1;
-
-       my $quitmsg;
-       seek(f, 0, 0); $. = 0;
-       while(<f>) {
-               next if ($. != $line);
-
-               chomp;
-               $quitmsg = $_;
-               last;
-       }
-       close(f);
+       my $quitmsg = $lines[int(rand(@lines))+1];
+       chomp($quitmsg);
+       close($fh);
 
        foreach my $server (Irssi::servers) {
                $server->command("/disconnect ".$server->{tag}." $quitmsg");