python,python3: remove `--with-system-ffi=no` config arg
authorAlexandru Ardelean <redacted>
Wed, 14 Mar 2018 14:21:40 +0000 (16:21 +0200)
committerAlexandru Ardelean <redacted>
Wed, 14 Mar 2018 14:21:41 +0000 (16:21 +0200)
Report https://github.com/openwrt/packages/issues/5638
It was mentioned that this causes build failures on Mac OS X.

The default behavior [in the setup.py script] is to check whether
`--with-system-ffi` is present in the CONFIG_ARGS env var.

However that back-fires a bit when `--with-system-ffi=no`, because the
condition `not '--with-system-ffi' in sysconfig.get_config_var("CONFIG_ARGS")`
evaluates to true.

This is a small bug in the `setup.py` script, but it looks like the
easiest/cleanest way to address it on our end is to just remove it entirely
from the HOST_CONFIGURE_ARGS.
At least that's how it looks like when testing on a Linux machine.

Signed-off-by: Alexandru Ardelean <redacted>
lang/python/python/Makefile
lang/python/python3/Makefile

index 5f698888a2651342bd50bc0f728030707da9cd4b..0948e350075b9a52e01ba00aa5752a2bcd7e7515 100644 (file)
@@ -282,7 +282,6 @@ HOST_CONFIGURE_ARGS+= \
        --prefix=$(HOST_PYTHON_DIR) \
        --exec-prefix=$(HOST_PYTHON_DIR) \
        --with-system-expat=$(STAGING_DIR_HOSTPKG) \
-       --with-system-ffi=no \
        --with-ensurepip=install \
        CONFIG_SITE=
 
index 794a2bf75e5538f6fb1b68f74cedf58d423a9a5b..85952c29868b368b36f6f25500196f42a73003c0 100644 (file)
@@ -278,7 +278,6 @@ HOST_CONFIGURE_ARGS+= \
        --prefix=$(HOST_PYTHON3_DIR) \
        --exec-prefix=$(HOST_PYTHON3_DIR) \
        --with-system-expat=$(STAGING_DIR_HOSTPKG) \
-       --with-system-ffi=no \
        --with-ensurepip=install \
        CONFIG_SITE=
 
git clone https://git.99rst.org/PROJECT