collectd: add percent calculation of bad block to ubi plugin
authorFlorian Eckert <redacted>
Thu, 11 Mar 2021 15:49:50 +0000 (16:49 +0100)
committerFlorian Eckert <redacted>
Tue, 23 Mar 2021 09:20:27 +0000 (10:20 +0100)
This patche adds the percent evaluation for the bad blocks.

Signed-off-by: Florian Eckert <redacted>
utils/collectd/patches/935-ubi-add-percent.patch [new file with mode: 0644]

diff --git a/utils/collectd/patches/935-ubi-add-percent.patch b/utils/collectd/patches/935-ubi-add-percent.patch
new file mode 100644 (file)
index 0000000..4736b85
--- /dev/null
@@ -0,0 +1,56 @@
+--- a/src/ubi.c
++++ b/src/ubi.c
+@@ -35,6 +35,9 @@
+ #define DEV_BAD_COUNT                                                          \
+   "bad_peb_count" // Count of bad physical eraseblocks on the underlying MTD
+                   // device.
++// Value reserved for bad block
++#define DEV_RESERVED_BAD_BLOCK "reserved_for_bad"
++
+ #define MAXIMUM_ERASE "max_ec" // Current maximum erase counter value
+ /*
+@@ -140,6 +143,35 @@ static inline int ubi_read_max_ec(const
+   return 0;
+ } /* int ubi_read_max_ec */
++static inline int ubi_read_percent(const char *dev_name) {
++  int ret;
++  int bcount;
++  int bblock;
++
++  ret = ubi_read_dev_attr(dev_name, DEV_BAD_COUNT, &bcount);
++
++  if (ret != 0) {
++    ERROR(PLUGIN_NAME " : Unable to read bad_peb_count");
++    return -1;
++  }
++
++  ret = ubi_read_dev_attr(dev_name, DEV_RESERVED_BAD_BLOCK, &bblock);
++
++  if (ret != 0) {
++    ERROR(PLUGIN_NAME " : Unable to read reserved_for_bad");
++    return -1;
++  }
++
++  if (bblock == 0) {
++    ERROR(PLUGIN_NAME " : Percentage value cannot be determined (reserved_for_bad = 0)");
++    return -2;
++  }
++
++  ubi_submit(dev_name, "percent", (gauge_t)((float_t)bcount / (float_t)bblock * 100.0));
++
++  return 0;
++} /* int ubi_read_percent */
++
+ static int ubi_read(void) {
+   DIR *dir;
+   struct dirent *dirent;
+@@ -155,6 +187,7 @@ static int ubi_read(void) {
+     ubi_read_dev_bad_count(dirent->d_name);
+     ubi_read_max_ec(dirent->d_name);
++    ubi_read_percent(dirent->d_name);
+   }
+   closedir(dir);
git clone https://git.99rst.org/PROJECT