ddns-scripts: refactor stop_daemon_for_all_ddns_sections()

Same functionality - code reads less 'shouty' and 'stabby'.

Signed-off-by: Paul Donald <redacted>

diff --git a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_functions.sh b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_functions.sh
index ba1572ec676235d2c974cd1d221f45dcbc9cd04c..5d15cbef7b0c02a248ccf2456d399eeae597c814 100644 (file)
--- a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_functions.sh
+++ b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_functions.sh
@@ -220,16 +220,14 @@ stop_section_processes() {
 # and by /etc/init.d/ddns stop
 # needed because we also need to kill "sleep" child processes
 stop_daemon_for_all_ddns_sections() {
-       local __EVENTIF="$1"
-       local __SECTIONS=""
-       local __SECTIONID=""
-       local __IFACE=""
-
-       load_all_service_sections __SECTIONS
-       for __SECTIONID in $__SECTIONS; do
-               config_get __IFACE "$__SECTIONID" interface "wan"
-               [ -z "$__EVENTIF" -o "$__IFACE" = "$__EVENTIF" ] || continue
-               stop_section_processes "$__SECTIONID"
+       local event_if sections section_id configured_if
+       event_if="$1"
+
+       load_all_service_sections sections
+       for section_id in $sections;    do
+               config_get configured_if "$section_id" interface "wan"
+               [ -z "$event_if" ] || [ "$configured_if" = "$event_if" ] || continue
+               stop_section_processes "$section_id"
        done
 }