luci-base: fix ubus getFeatures() crash

OpenWrt versions that provide odhcpd versions reporting a compile time
features line in their help output trigger a crash in the getFeatures()
procedure (attempt to set property on boolean value) - fix this issue
by not predeclaring the odhcpd flag as `false`.

Fixes: #8489
Fixes: 0529dca7a2 ("luci-base: fix feature detection patterns")
Signed-off-by: Jo-Philipp Wich <redacted>

diff --git a/modules/luci-base/root/usr/share/rpcd/ucode/luci b/modules/luci-base/root/usr/share/rpcd/ucode/luci
index 511853cd71decf660761af666020e31f50acb7fb..ca95ded897403e6aa2a1e30d8528ce614b4bc177 100644 (file)
--- a/modules/luci-base/root/usr/share/rpcd/ucode/luci
+++ b/modules/luci-base/root/usr/share/rpcd/ucode/luci
@@ -291,7 +291,6 @@ const methods = {
                                fd.close();
                        }
 
-                       result.odhcpd = false;
                        fd = popen('odhcpd -h 2>/dev/null');
 
                        if (fd) {