compat/setenv.c: error if name contains '='

According to POSIX, setenv should error out with EINVAL if it's
asked to set an environment variable whose name contains an equals
sign. Implement this detail in our compatibility-fallback.

Signed-off-by: Erik Faye-Lund <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/compat/setenv.c b/compat/setenv.c
index 89947b7134a7671c7f035e48bf8cd5f3ce4bc7c4..fc1439a6439393ff5224e98ab126607ceaa4994d 100644 (file)
--- a/compat/setenv.c
+++ b/compat/setenv.c
@@ -6,7 +6,7 @@ int gitsetenv(const char *name, const char *value, int replace)
        size_t namelen, valuelen;
        char *envstr;
 
-       if (!name || !value) {
+       if (!name || strchr(name, '=') || !value) {
                errno = EINVAL;
                return -1;
        }