ddns-scripts: variable quoting
authorPaul Donald <redacted>
Sat, 30 Nov 2024 18:16:11 +0000 (19:16 +0100)
committerFlorian Eckert <redacted>
Thu, 10 Apr 2025 07:34:38 +0000 (09:34 +0200)
in case spaces should creep into path names

Signed-off-by: Paul Donald <redacted>
net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_lucihelper.sh

index f76334848d75ec73f299870fa17dcf49cd7f1131..c57e1cf39b1537c5ddc7794d9b606d68967cd1d2 100644 (file)
@@ -147,19 +147,19 @@ case "$1" in
                ;;
        start)
                [ -z "$SECTION" ] &&  usage_err "command 'start': 'SECTION' not set"
-               if [ $VERBOSE -eq 0 ]; then     # start in background
-                       $DDNSPRG -v 0 -S $SECTION -- start &
+               if [ "$VERBOSE" -eq 0 ]; then   # start in background
+                       "$DDNSPRG" -v 0 -S "$SECTION" -- start &
                else
-                       $DDNSPRG -v $VERBOSE -S $SECTION -- start
+                       "$DDNSPRG" -v "$VERBOSE" -S "$SECTION" -- start
                fi
                ;;
        reload)
-               $DDNSPRG -- reload
+               "$DDNSPRG" -- reload
                ;;
        restart)
-               $DDNSPRG -- stop
+               "$DDNSPRG" -- stop
                sleep 1
-               $DDNSPRG -- start
+               "$DDNSPRG" -- start
                ;;
        *)
                __RET=255
@@ -167,6 +167,6 @@ case "$1" in
 esac
 
 # remove out and err file
-[ -f $DATFILE ] && rm -f $DATFILE
-[ -f $ERRFILE ] && rm -f $ERRFILE
+[ -f "$DATFILE" ] && rm -f "$DATFILE"
+[ -f "$ERRFILE" ] && rm -f "$ERRFILE"
 return $__RET
git clone https://git.99rst.org/PROJECT