[sysinfoplus][crit] rewrite open; move strict

diff --git a/_testing/config.yml b/_testing/config.yml
index 34c9c6d2e4a478bddfe0814e0391a231ed044456..ee7f77e60563ac2afbe65d9cc4f66c4d3ec5d05c 100644 (file)
--- a/_testing/config.yml
+++ b/_testing/config.yml
@@ -57,7 +57,6 @@ whitelist:
   - quizmaster
   - quiz
   - stocks
-  - sysinfoplus
   - tvmusor
   - wordcompletition
   - xetra

diff --git a/scripts/sysinfoplus.pl b/scripts/sysinfoplus.pl
index cc82d0d6f1b9c2488d00a70167b2417262db34f3..fc0cff085b1a46b162167195afd8904edc62925d 100644 (file)
--- a/scripts/sysinfoplus.pl
+++ b/scripts/sysinfoplus.pl
@@ -16,8 +16,10 @@
 # -Total amount of memory counts (not the used amount, as before)
 
 # Changelog 2.10 -> 2.20: memory/swap info is displayed now (it was broken previously) and code is properly indented
+use strict;
+use vars qw/$VERSION %IRSSI/;
 
-$VERSION = "2.20";
+$VERSION = "2.21";
 %IRSSI = (
          authors     => "Juerd, Tronic",
          contact     => "trn\@iki.fi",
@@ -25,7 +27,7 @@ $VERSION = "2.20";
          description => "Linux system information (with vPenis and other stuff)",
          license     => "Public Domain",
          url         => "http://juerd.nl/irssi/",
-         changed     => "Mon Nov 04 15:17:30 EET 2002"
+         changed     => "2017-04-02"
          );
 
 BEGIN{
@@ -37,7 +39,6 @@ BEGIN{
     $console = !!$@;
 }
 
-use strict;
 
 # Tronic has no time for maintaining this and Juerd hates braces, so it might be better
 # not to expect any new versions ...
@@ -51,7 +52,7 @@ sub sysinfo{
     
     $ret = "Host '@uname[1]', running @uname[0] @uname[2] - ";
     
-    open FOO, '/proc/cpuinfo';
+    open FOO,'<', '/proc/cpuinfo';
     while (<FOO>){
        /^processor\s*:\s*(\d+)/         ? $ret .= "Cpu$1: "
          : /^model name\s*:\s*(\w+[ A-Za-z]*)/ ? do { my $t = $1; $t =~ s/\s+$//; $ret .= "$t " }
@@ -60,7 +61,7 @@ sub sysinfo{
     }
     close FOO;
     $ret =~ s/( ?)$/;$1/;
-    open FOO, '/proc/pci';
+    open FOO,'<', '/proc/pci';
     while (<FOO>){
        /^\s*(?:multimedia )?(.*?)( storage| compatible)? controller/i and push @pci, $1;
     }