commit-graph.c: prevent overflow in `load_tree_for_commit()`

In a similar spirit as previous commits, ensure that we don't overflow
when computing an offset into the commit_data chunk when the (relative)
graph position exceeds 2^32-1/GRAPH_DATA_WIDTH.

Signed-off-by: Taylor Blau <redacted>
Signed-off-by: Junio C Hamano <redacted>

diff --git a/commit-graph.c b/commit-graph.c
index 5e32063d3dce484de3520011bdc5264f9f97aef3..08d773567f362061d8f88d07dd424e4bca719d97 100644 (file)
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -980,7 +980,7 @@ static struct tree *load_tree_for_commit(struct repository *r,
                g = g->base_graph;
 
        commit_data = g->chunk_commit_data +
-                       GRAPH_DATA_WIDTH * (graph_pos - g->num_commits_in_base);
+                       st_mult(GRAPH_DATA_WIDTH, graph_pos - g->num_commits_in_base);
 
        oidread(&oid, commit_data);
        set_commit_tree(c, lookup_tree(r, &oid));