Remove Superfluous Check for Zero-Length List
authorAnkit Pati <redacted>
Fri, 9 Mar 2018 18:44:20 +0000 (00:14 +0530)
committerAnkit Pati <redacted>
Fri, 9 Mar 2018 19:08:31 +0000 (00:38 +0530)
Checking for zero-length is not necessary here as iterating over a
zero-length list is perfectly valid, and produces exactly zero
iterations, matching the intended behaviour without an extra check.

updateHostsFile.py

index 1f3a2e52e251eca504e7e761839968f77c25826a..e319aa0892aa3e941a02a3ef1e77ff8435a28c33 100644 (file)
@@ -620,9 +620,8 @@ def update_all_sources(source_data_filename, host_filename):
             updated_file = get_file_by_url(update_url)
 
             # spin the transforms as required
-            if len(update_transforms) > 0:
-                for transform in update_transforms:
-                    updated_file = transform_methods[transform](updated_file)
+            for transform in update_transforms:
+                updated_file = transform_methods[transform](updated_file)
 
             # get rid of carriage-return symbols
             updated_file = updated_file.replace("\r", "")
git clone https://git.99rst.org/PROJECT