]> git.99rst.org Git - git.git/commitdiff
blame: use "goto cleanup" for cleanup_scoreboard()
authorÆvar Arnfjörð Bjarmason <redacted>
Wed, 13 Apr 2022 20:01:31 +0000 (22:01 +0200)
committerJunio C Hamano <redacted>
Thu, 14 Apr 2022 06:56:08 +0000 (23:56 -0700)
Amend a freeing pattern added in 0906ac2b54b (blame: use changed-path
Bloom filters, 2020-04-16) to use a "goto cleanup", so that we can be
sure that we call cleanup_scoreboard().

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
Signed-off-by: Junio C Hamano <redacted>
builtin/blame.c

index 8d15b68afc9da3ffe0e1bce952e1e0fe72afd428..885b381ab83a9c6dee19753481a1aa6ffad41d28 100644 (file)
@@ -1167,7 +1167,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
        if (!incremental)
                setup_pager();
        else
-               return 0;
+               goto cleanup;
 
        blame_sort_final(&sb);
 
@@ -1201,6 +1201,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
                printf("num commits: %d\n", sb.num_commits);
        }
 
+cleanup:
        cleanup_scoreboard(&sb);
        return 0;
 }
git clone https://git.99rst.org/PROJECT