net-snmp: add early return when HostIP is unset

snmpd_access_HostIP_add would write unintended output to the
config file if the HostIP option is not specified. Add an early
return to prevent writing in that case.

This is a breaking change for configs where HostIP is unset.
Previously, an empty HostIP option would result in a malformed
directive containing a bare /mask with no guaranteed newline, the
exact form of which depended on the values of other options.
Now, no directive is written.

Signed-off-by: Eric McDonald <redacted>

diff --git a/net/net-snmp/files/snmpd.init b/net/net-snmp/files/snmpd.init
index 7c1a7429b76ae434c451c1300f03e16d966c75eb..b1e13edb11af64e41a29773aa3cd10a84d93925e 100644 (file)
--- a/net/net-snmp/files/snmpd.init
+++ b/net/net-snmp/files/snmpd.init
@@ -158,6 +158,7 @@ snmpd_access_HostName_add() {
 snmpd_access_HostIP_add() {
        local cfg="$1"
        config_get host_ip "$cfg" HostIP
+       [ -n "$host_ip" ] || return 0
        config_get ip_mask "$cfg" IPMask
        config_get mode "$cfg" Mode
        [ -n "$mode" ] || return 0