Make sure to close files
authorDennis van de Hoef <redacted>
Fri, 26 May 2023 15:38:29 +0000 (17:38 +0200)
committerSteven Black <redacted>
Mon, 12 Jun 2023 02:32:17 +0000 (22:32 -0400)
updateHostsFile.py

index fc6bf19155266fa1e920b9e79566e6a770507469..5c8271492cf70845f40d87437ee5914910ce4847 100755 (executable)
@@ -695,9 +695,11 @@ def update_sources_data(sources_data, **sources_params):
             recursive_glob(sources_params["datapath"], source_data_filename)
         ):
             update_file = open(source, "r", encoding="UTF-8")
-            update_data = json.load(update_file)
-            sources_data.append(update_data)
-            update_file.close()
+            try:
+                update_data = json.load(update_file)
+                sources_data.append(update_data)
+            finally:
+                update_file.close()
 
     for source in sources_params["extensions"]:
         source_dir = path_join_robust(sources_params["extensionspath"], source)
@@ -705,10 +707,11 @@ def update_sources_data(sources_data, **sources_params):
             recursive_glob(source_dir, source_data_filename)
         ):
             update_file = open(update_file_path, "r")
-            update_data = json.load(update_file)
-
-            sources_data.append(update_data)
-            update_file.close()
+            try:
+                update_data = json.load(update_file)
+                sources_data.append(update_data)
+            finally:
+                update_file.close()
 
     return sources_data
 
git clone https://git.99rst.org/PROJECT