git.99rst.org / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 98f85ff)
refs.c: fix fread error handling
authorJohn Keeping <redacted>
Sat, 23 Mar 2013 17:16:46 +0000 (17:16 +0000)
committerJunio C Hamano <redacted>
Sun, 24 Mar 2013 06:50:50 +0000 (23:50 -0700)
commite4ca819abff48af8e4a10059c88b3b1533b9f994
tree8eac07ff308aa6c1bf882c9fa010084ab76ae0abtree | snapshot
parent98f85ff4b65b565bae0592ded494d67045cbd3bfcommit | diff
refs.c: fix fread error handling

fread returns the number of items read, with no special error return.

Commit 98f85ff (reflog: add for_each_reflog_ent_reverse() API -
2013-03-08) introduced a call to fread which checks for an error with
"nread < 0" which is tautological since nread is unsigned.  The correct
check in this case (which tries to read a single item) is "nread != 1".

Signed-off-by: John Keeping <redacted>
Signed-off-by: Junio C Hamano <redacted>
refs.c diff | blob | history
git clone https://git.99rst.org/PROJECT