]> git.99rst.org Git - openwrt-packages.git/commit
nodogsplash: fix config generation in the init script
authorJosef Schlehofer <redacted>
Thu, 6 Aug 2026 10:55:52 +0000 (12:55 +0200)
committerJosef Schlehofer <redacted>
Sat, 15 Aug 2026 21:31:16 +0000 (23:31 +0200)
commitb8dc6c707750dc2fa26afef1aa71b20d2a89f775
tree5aa95bd5272e3cc0ed50cf19918a0735b140d34d
parentdcde8f02705e98a1f43ed386a2615a36b8ac120f
nodogsplash: fix config generation in the init script

Three problems in the generated configuration:

- The error message for a missing configuration file prints $file,
  which is never set, instead of $val, which holds the path.
- The warning for the unsupported FAS options prints the value of
  the option instead of its name, so the message does not say which
  option is unsupported.
- gatewayinterface is emitted twice: once resolved to a device via
  network_get_device() as "GatewayInterface", and once more by the
  generic option loop with the raw UCI value. When the value names a
  network section rather than a device, the second line overrides
  the resolved device with a name nodogsplash cannot use.

Reported-by: openwrt-ai[bot]
Signed-off-by: Josef Schlehofer <redacted>
Co-authored-by: Claude Fable 5 <redacted>
net/nodogsplash/files/etc/init.d/nodogsplash
git clone https://git.99rst.org/PROJECT