merge-ort: add implementation of both sides renaming identically
authorElijah Newren <redacted>
Tue, 15 Dec 2020 18:28:01 +0000 (18:28 +0000)
committerJunio C Hamano <redacted>
Wed, 16 Dec 2020 01:18:32 +0000 (17:18 -0800)
commitaf1e56c49e61a39d5a7d78cecb97f350b5a3834a
treedbd2b8527a7c3a60862ceb498b3044bf30e3373d
parentc2d267df0215d49f06638463889465389134021a
merge-ort: add implementation of both sides renaming identically

Implement rename/rename(1to1) handling, i.e. both sides of history
renaming a file but renaming the same way.  This code replaces the
following from merge-recurisve.c:

  * all the 1to1 code in process_renames()
  * the RENAME_ONE_FILE_TO_ONE case of process_entry()

Also, there is some shared code from merge-recursive.c for multiple
different rename cases which we will no longer need for this case (or
other rename cases):

  * handle_rename_normal()
  * setup_rename_conflict_info()

The consolidation of four separate codepaths into one is made possible
by a change in design: process_renames() tweaks the conflict_info
entries within opt->priv->paths such that process_entry() can then
handle all the non-rename conflict types (directory/file, modify/delete,
etc.) orthogonally.  This means we're much less likely to miss special
implementation of some kind of combination of conflict types (see
commits brought in by 66c62eaec6 ("Merge branch 'en/merge-tests'",
2020-11-18), especially commit ef52778708 ("merge tests: expect improved
directory/file conflict handling in ort", 2020-10-26) for more details).
That, together with letting worktree/index updating be handled
orthogonally in the merge_switch_to_result() function, dramatically
simplifies the code for various special rename cases.

Signed-off-by: Elijah Newren <redacted>
Signed-off-by: Junio C Hamano <redacted>
merge-ort.c
git clone https://git.99rst.org/PROJECT