gc: remove redundant check for gc_auto_threshold
authorÆvar Arnfjörð Bjarmason <redacted>
Wed, 13 Mar 2019 23:54:35 +0000 (00:54 +0100)
committerJunio C Hamano <redacted>
Thu, 14 Mar 2019 04:55:28 +0000 (13:55 +0900)
commit8bf14444c3989aa0f5b01ba67dfb4b592e6c30d3
tree96a015aa2d312ea9e31cd12d6b9649bab54e0d51
parente902e9bcae2010bc42648c80ab6adc6c5a16a4a5
gc: remove redundant check for gc_auto_threshold

Checking gc_auto_threshold in too_many_loose_objects() was added in
17815501a8 ("git-gc --auto: run "repack -A -d -l" as necessary.",
2007-09-17) when need_to_gc() itself was also reliant on
gc_auto_pack_limit before its early return:

    gc_auto_threshold <= 0 && gc_auto_pack_limit <= 0

When that check was simplified to just checking "gc_auto_threshold <=
0" in b14d255ba8 ("builtin-gc.c: allow disabling all auto-gc'ing by
assigning 0 to gc.auto", 2008-03-19) this unreachable code should have
been removed. We only call too_many_loose_objects() from within
need_to_gc() itself, which will return if this condition holds, and in
cmd_gc() which will return before ever getting to "auto_gc &&
too_many_loose_objects()" if "auto_gc && !need_to_gc()" is true
earlier in the function.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
Signed-off-by: Junio C Hamano <redacted>
builtin/gc.c
git clone https://git.99rst.org/PROJECT