]> git.99rst.org Git - git.git/commit
transport-helper: fix memory leak of helper on disconnect
authorPablo Sabater <redacted>
Fri, 24 Jul 2026 10:54:12 +0000 (12:54 +0200)
committerJunio C Hamano <redacted>
Fri, 24 Jul 2026 15:46:58 +0000 (08:46 -0700)
commit840eb9a1c54f76b1e16b249eb3f4240c3622daf3
treeb16474914205d4a576ee52edcbc63b1e740cf05a
parent41365c2a9ba347870b80881c0d67454edd22fd49
transport-helper: fix memory leak of helper on disconnect

disconnect_helper() only frees data inside of the if(data->helper) block
[1]. When the transport is disconnected without the helper being fully
started, data->name allocated in transport_helper_init()
is never freed.

Move FREE_AND_NULL(data->name) outside the conditional block so it's
always freed on disconnect.

[1]: https://lore.kernel.org/git/05fbadbae2184479c87c37675dde7bd79b3e32ab.1716465556.git.ps@pks.im/

Mentored-by: Karthik Nayak <redacted>
Mentored-by: Chandra Pratap <redacted>
Signed-off-by: Pablo Sabater <redacted>
Signed-off-by: Junio C Hamano <redacted>
transport-helper.c
git clone https://git.99rst.org/PROJECT