]> git.99rst.org Git - git.git/commit
fetch-pack: buffer object-format with other args
authorJonathan Tan <redacted>
Fri, 9 Apr 2021 01:09:58 +0000 (18:09 -0700)
committerJunio C Hamano <redacted>
Fri, 9 Apr 2021 04:49:47 +0000 (21:49 -0700)
commit81ed96a9b2c5ad8a3b1ea04fd6cd273557b76c58
treec753af4e2363d70b775352b82819d785fe11d50d
parente4f4299859610638e45ec1a36266973b9a4eb47a
fetch-pack: buffer object-format with other args

In send_fetch_request(), "object-format" is written directly to the file
descriptor, as opposed to the other arguments, which are buffered.
Buffer "object-format" as well. "object-format" must be buffered; in
particular, it must appear after "command=fetch" in the request.

This divergence was introduced in 4b831208bb ("fetch-pack: parse and
advertise the object-format capability", 2020-05-27), perhaps as an
oversight (the surrounding code at the point of this commit has already
been using a request buffer.)

Signed-off-by: Jonathan Tan <redacted>
Signed-off-by: Junio C Hamano <redacted>
fetch-pack.c
git clone https://git.99rst.org/PROJECT