]> git.99rst.org Git - git.git/commit
strbuf: avoid redundant reset in strbuf_getwholeline()
authorRené Scharfe <redacted>
Tue, 14 Jul 2026 08:45:59 +0000 (10:45 +0200)
committerJunio C Hamano <redacted>
Tue, 14 Jul 2026 16:35:02 +0000 (09:35 -0700)
commit7b0203b15c1a15c77436160c58b45bef9b087c08
treec8139326c42fe597c1e5d3fe1a2f9de8eca2c319
parente9019fcafe0040228b8631c30f97ae1adb61bcdc
strbuf: avoid redundant reset in strbuf_getwholeline()

The HAVE_GETDELIM variant of strbuf_getwholeline() calls strbuf_reset()
on the strbuf before handing it over to getdelim(3).  This is
unnecessary:

  - getdelim(3) doesn't care whether the old buffer contents is
    NUL-terminated and has no access to ->len,
  - on success getdelim(3) NUL-terminates the buffer and we set ->len,
  - on error we either call strbuf_init() or strbuf_reset().

Remove the superfluous preparatory call.

Signed-off-by: René Scharfe <redacted>
Signed-off-by: Junio C Hamano <redacted>
strbuf.c
git clone https://git.99rst.org/PROJECT