mingw: improve performance of mingw_unlink()
authorJeff Hostetler <redacted>
Mon, 17 Aug 2020 10:37:02 +0000 (10:37 +0000)
committerJunio C Hamano <redacted>
Mon, 17 Aug 2020 18:27:16 +0000 (11:27 -0700)
commit680e0b4524482c4bb679030188f6ae8db4caff06
tree88b5f31084a0bd74597d96a64d76e7c5c4bbd271
parent47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc
mingw: improve performance of mingw_unlink()

Update mingw_unlink() to first try to delete the file with existing
permissions before trying to force it.

Windows throws an error when trying to delete a read-only file.  The
mingw_unlink() compatibility wrapper always tries to _wchmod(666) the
file before calling _wunlink() to avoid that error.  However, since
most files in the worktree are already writable, this is usually
wasted effort.

Update mingw_unlink() to just call DeleteFileW() directly and if that
succeeds return.  If that fails, fall back into the existing code path
to update the permissions and use _wunlink() to get the existing
error code mapping.

Signed-off-by: Jeff Hostetler <redacted>
Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Junio C Hamano <redacted>
compat/mingw.c
git clone https://git.99rst.org/PROJECT