upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'
authorTaylor Blau <redacted>
Mon, 3 Aug 2020 18:00:17 +0000 (14:00 -0400)
committerJunio C Hamano <redacted>
Tue, 4 Aug 2020 01:03:46 +0000 (18:03 -0700)
commit5b01a4e8ff19fa9797a67b53df2db0a1a574fe81
tree611f65243e8bec6abe5c6192fb25f35e888bf95a
parent6dd3456a8ccbad6a0a6a31bc7192025617114243
upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'

In b79cf959b2 (upload-pack.c: allow banning certain object filter(s),
2020-02-26), we introduced functionality to disallow certain object
filters from being chosen from within 'git upload-pack'. Traditionally,
administrators use this functionality to disallow filters that are known
to perform slowly, for e.g., those that do not have bitmap-level
filtering.

In the past, the '--filter=tree:<n>' was one such filter that does not
have bitmap-level filtering support, and so was likely to be banned by
administrators.

However, in the previous couple of commits, we introduced bitmap-level
filtering for the case when 'n' is equal to '0', i.e., as if we had a
'--filter=tree:none' choice.

While it would be sufficient to simply write

  $ git config uploadpackfilter.tree.allow true

(since it would allow all values of 'n'), we would like to be able to
allow this filter for certain values of 'n', i.e., those no greater than
some pre-specified maximum.

In order to do this, introduce a new configuration key, as follows:

  $ git config uploadpackfilter.tree.maxDepth <m>

where '<m>' specifies the maximum allowed value of 'n' in the filter
'tree:n'. Administrators who wish to allow for only the value '0' can
write:

  $ git config uploadpackfilter.tree.allow true
  $ git config uploadpackfilter.tree.maxDepth 0

which allows '--filter=tree:0', but no other values.

Signed-off-by: Taylor Blau <redacted>
Acked-by: Jeff King <redacted>
Signed-off-by: Junio C Hamano <redacted>
Documentation/config/uploadpack.txt
t/t5616-partial-clone.sh
upload-pack.c
git clone https://git.99rst.org/PROJECT