find_reference_location(): make function safe for empty snapshots
authorMichael Haggerty <redacted>
Wed, 24 Jan 2018 11:14:13 +0000 (12:14 +0100)
committerJunio C Hamano <redacted>
Wed, 24 Jan 2018 20:55:26 +0000 (12:55 -0800)
commit4a14f8d093138a313070fd6a50204eda66c1f9eb
treedd2a8d461a25cc336cdcf2ce0e7f351dbdaf0a7c
parent27a41841ec7f83b3b1078c400f149bc536e796a4
find_reference_location(): make function safe for empty snapshots

This function had two problems if called for an empty snapshot (i.e.,
`snapshot->start == snapshot->eof == NULL`):

* It checked `NULL < NULL`, which is undefined by C (albeit highly
  unlikely to fail in the real world).

* (Assuming the above comparison behaved as expected), it returned
  NULL when `mustexist` was false, contrary to its docstring.

Change the check and fix the docstring.

Signed-off-by: Michael Haggerty <redacted>
Signed-off-by: Junio C Hamano <redacted>
refs/packed-backend.c
git clone https://git.99rst.org/PROJECT