git.99rst.org / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9afbb2d)
git-p4: fix handling of multi-word P4EDITOR
authorLuke Diamand <redacted>
Tue, 19 May 2015 22:23:17 +0000 (23:23 +0100)
committerJunio C Hamano <redacted>
Sun, 24 May 2015 18:50:12 +0000 (11:50 -0700)
commit2dade7a7b20902a145d1c130830bcb4d4b288a32
treeeb09f361703fcae2512578be2078c502747efffetree | snapshot
parent9afbb2dc371441ad250d5e094277699b58dbd88ccommit | diff
git-p4: fix handling of multi-word P4EDITOR

This teaches git-p4 to pass the P4EDITOR variable to the
shell for expansion, so that any command-line arguments are
correctly handled. Without this, git-p4 can only launch the
editor if P4EDITOR is solely the path to the binary, without
any arguments.

This also adjusts t9805, which relied on the previous behaviour.

Suggested-by: Jonathan Nieder <redacted>
Signed-off-by: Luke Diamand <redacted>
Signed-off-by: Junio C Hamano <redacted>
git-p4.py diff | blob | history
t/t9805-git-p4-skip-submit-edit.sh diff | blob | history
t/t9820-git-p4-editor-handling.sh diff | blob | history
git clone https://git.99rst.org/PROJECT