git.99rst.org / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 898f807)
diff: allow passing NULL to diff_free_filespec_data()
authorJinoh Kang <redacted>
Fri, 6 Nov 2020 17:14:52 +0000 (17:14 +0000)
committerJunio C Hamano <redacted>
Fri, 6 Nov 2020 19:37:07 +0000 (11:37 -0800)
commit246959346f3407cb047c3d46ed9c44da84bd0b29
tree60f01c3e43913becdafbffe2b7df9c850b58e368tree | snapshot
parent898f80736c75878acc02dc55672317fcc0e0a5a6commit | diff
diff: allow passing NULL to diff_free_filespec_data()

Commit 3aef54e8b8 ("diff: munmap() file contents before running external
diff") introduced calls to diff_free_filespec_data in
run_external_diff, which may pass NULL pointers.

Fix this and prevent any such bugs in the future by making
`diff_free_filespec_data(NULL)` a no-op.

Fixes: 3aef54e8b8 ("diff: munmap() file contents before running external diff")
Signed-off-by: Jinoh Kang <redacted>
Signed-off-by: Junio C Hamano <redacted>
diff.c diff | blob | history
t/t7800-difftool.sh diff | blob | history
git clone https://git.99rst.org/PROJECT