t3904: fix incorrect demonstration of a bug
authorJohannes Schindelin <redacted>
Wed, 8 Apr 2020 18:52:33 +0000 (18:52 +0000)
committerJunio C Hamano <redacted>
Wed, 8 Apr 2020 19:17:58 +0000 (12:17 -0700)
commit121c0d4151a602f528887486d627a7230abbd85d
tree0bcf88d965b4b878d60f8ea209faaf943242673d
parent274b9cc25322d9ee79aa8e6d4e86f0ffe5ced925
t3904: fix incorrect demonstration of a bug

In 7e9e048661 (stash -p: demonstrate failure of split with mixed y/n,
2015-04-16), a regression test for a known breakage that was added to
the test script `t3904-stash-patch.sh` that demonstrated that splitting
a hunk and trying to stash only part of that split hunk fails (but
shouldn't).

As expected, it still fails, but for the wrong reason: once the bug is
fixed, we would expect stderr to show nothing, yet the regression test
expects stderr to show something.

Let's fix that by telling that regression test case to expect nothing to
be printed to stderr.

While at it, also drop the obvious left-over from debugging where the
regression test did not mind `git stash -p` to return a non-zero exit
status.

Of course, the regression test still fails, but this time for the
correct reason.

Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Junio C Hamano <redacted>
t/t3904-stash-patch.sh
git clone https://git.99rst.org/PROJECT