git.99rst.org Git - openwrt-packages.git/blob

   1 From 4f7778ed232a92bde388f38917b94f458a82c78e Mon Sep 17 00:00:00 2001
   2 From: Chrostoper Ertl <chertl@microsoft.com>
   3 Date: Thu, 28 Nov 2019 16:51:49 +0000
   4 Subject: [PATCH 08/11] session: Fix buffer overflow in ipmi_get_session_info
   5
   6 Partial fix for CVE-2020-5208, see
   7 https://github.com/ipmitool/ipmitool/security/advisories/GHSA-g659-9qxw-p7cp
   8
   9 The `ipmi_get_session_info` function does not properly check the
  10 response `data_len`, which is used as a copy size, allowing stack buffer
  11 overflow.
  12 ---
  13  lib/ipmi_session.c | 12 ++++++++----
  14  1 file changed, 8 insertions(+), 4 deletions(-)
  15
  16 --- a/lib/ipmi_session.c
  17 +++ b/lib/ipmi_session.c
  18 @@ -309,8 +309,10 @@ ipmi_get_session_info(struct ipmi_intf
  19                 }
  20                 else
  21                 {
  22 -                       memcpy(&session_info,  rsp->data, rsp->data_len);
  23 -                       print_session_info(&session_info, rsp->data_len);
  24 +                       memcpy(&session_info,  rsp->data,
  25 +                              __min(rsp->data_len, sizeof(session_info)));
  26 +                       print_session_info(&session_info,
  27 +                                          __min(rsp->data_len, sizeof(session_info)));
  28                 }
  29                 break;
  30
  31 @@ -341,8 +343,10 @@ ipmi_get_session_info(struct ipmi_intf
  32                                 break;
  33                         }
  34
  35 -                       memcpy(&session_info,  rsp->data, rsp->data_len);
  36 -                       print_session_info(&session_info, rsp->data_len);
  37 +                       memcpy(&session_info,  rsp->data,
  38 +                              __min(rsp->data_len, sizeof(session_info)));
  39 +                       print_session_info(&session_info,
  40 +                                          __min(rsp->data_len, sizeof(session_info)));
  41
  42                 } while (i <= session_info.session_slot_count);
  43                 break;